-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update eth-secpm.md #35
Conversation
Added flow diagrams
vac/70/eth-secpm.md
Outdated
|
||
Below follows the flow diagram for the generation of credentials. | ||
Users MUST generate key pairs by themselves. | ||
![credentials](https://github.com/vacp2p/rfc-index/assets/74050285/04011f8f-db01-4ae1-a720-1865d4c4d143) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these images are meant to be uploaded to the rfc-index, can you do that? and reference them this way?
context:
waku-rln-relay rfc-index: https://github.com/vacp2p/rfc-index/blob/69f28534075d1486ebff0f292cd4e2fa80f6fd1b/waku/standards/core/17/rln-relay.md?plain=1#L62C1-L62C51
and the images go in the spec/images directory
https://github.com/vacp2p/rfc-index/tree/main/waku/standards/core/17/images
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the flow diagrams, it is still not clear what the authentication service should actually return. maybe i am missing something, but more context would be helpful here, thanks!
@ramsesfv please update the branch and merge :) |
Added flow diagrams