Skip to content

Commit

Permalink
address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
chaitanyaprem committed Jan 2, 2025
1 parent cb2b047 commit 04e1588
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions waku/informational/23/topics.md
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,8 @@ As an example, here's the content topic used for an upcoming testnet:

### Content Topic Naming Recommendations

Application names should be unique to avoid conflicting issues with other protocols.
Applications should specify their version (if applicable) in the version field.
Application names SHOULD be unique to avoid conflicting issues with other protocols.
Applications SHOULD specify their version (if applicable) in the version field.
The `{content-topic-name}` portion of the content topic is up to the application,
and depends on the problem domain.
It can be hierarchical, for instance to separate content, or
Expand All @@ -131,14 +131,14 @@ for the [WakuMessage payload](../../standards/core/14/message.md/#payloads) fiel

### Content Topic usage guidelines

Applications should be mindful while designing/using content topics so that a bloat of content-topics does not happen.
A content-topic bloat causes performance degradation in [13/WAKU2 -STORE](/waku/standards/core/13/store.md) and [12/WAKU2-FILTER](/waku/standards/core/13/filter.md) protocols while trying to retrieve messages.
Applications SHOULD be mindful while designing/using content topics so that a bloat of content-topics does not happen.
A content-topic bloat causes performance degradation in Store and Filter protocols while trying to retrieve messages.

Store queries have been noticed to be considerably slow (e.g doubling of response-time when content-topic count is increased from 10 to 100) when a lot of content-topics are involved in a single query.
Similarly number of filter subscriptions increase, which increases complexity on client side to maintain and manage these subscriptions.

Applications should analyze the query/filter criteria for fetching messages from the network and select/design content topics to match such filter criteria.
e.g: even though applications may want to segregate messages into different sets based on some application logic, if those sets of messages are always fetched/queried together from the network, then all those messages should use a single content-topic.
Applications SHOULD analyze the query/filter criteria for fetching messages from the network and select/design content topics to match such filter criteria.
e.g: even though applications may want to segregate messages into different sets based on some application logic, if those sets of messages are always fetched/queried together from the network, then all those messages SHOULD use a single content-topic.


## Differences with Waku v1
Expand Down

0 comments on commit 04e1588

Please sign in to comment.