Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: destroy chart instance when disconnected from the DOM (#7785) (CP: 23.5) #8104

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

DiegoCardoso
Copy link
Contributor

Description

Cherry-pick of #7785.

This is needed in 23.5 as it can be used as a workaround for the BFP issue reported in vaadin/flow-components#6383 while there isn't a fix for the underlying issue in Highcharts.

Depends on #8103

@DiegoCardoso DiegoCardoso marked this pull request as ready for review November 7, 2024 12:53
Copy link

sonarcloud bot commented Nov 7, 2024

@DiegoCardoso DiegoCardoso merged commit ae8253c into 23.5 Nov 7, 2024
10 checks passed
@DiegoCardoso DiegoCardoso deleted the cp/23.5/destroy-charts-on-detach branch November 7, 2024 13:18
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 23.5.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants