refactor: export i18n defaults for using in date-time-pickers #8081
+70
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
refactor/dtp-i18n-defaults
branch
2 times, most recently
from
8c3ab4c
to
02891b1
Compare
web-padawan
force-pushed
the
refactor/dtp-i18n-defaults
branch
from
02891b1
to
8d8a9c8
Compare
|
This was referenced Nov 4, 2024
tomivirkki
approved these changes
Nov 4, 2024
|
This ticket/PR has been released with Vaadin 24.6.0.alpha3 and is also targeting the upcoming stable 24.6.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Exposed defaults to avoid getting
i18nvalues fromDatePickerandTimePickerprototypes.Also changed to not use
target.set()(Polymer API) and set the wholei18nobject instead.This is a pre-requisite for extracting
vaadin-date-time-pickerlogic into a mixin for Lit version.Type of change