Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: disable error-message transition in visual tests #7830

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

web-padawan
Copy link
Member

Description

Part of #7823

This should fix the following errors where the screenshot seems to be taken while error message transition is in progress:

 ❌ multi-select-combo-box > error message
      Error: Screenshot is not the same width and height as the baseline. Baseline: { width: 212, height: 124 } Screenshot: { width: 212, height: 121 }
        at async Ka.<anonymous> (packages/multi-select-combo-box/test/visual/lumo/multi-select-combo-box.test.js:73:5)

 ❌ text-area > error message
      Error: Screenshot is not the same width and height as the baseline. Baseline: { width: 212, height: 146 } Screenshot: { width: 212, height: 138 }
        at async n.<anonymous> (packages/text-area/test/visual/lumo/text-area.test.js:74:5)

Type of change

  • Tests

@web-padawan web-padawan force-pushed the test/error-message-disable-transition branch from 18b026b to 06eeca3 Compare September 20, 2024 08:28
Copy link

sonarcloud bot commented Sep 20, 2024

@web-padawan web-padawan merged commit 1bf32d1 into main Sep 20, 2024
9 checks passed
@web-padawan web-padawan deleted the test/error-message-disable-transition branch September 20, 2024 09:57
web-padawan added a commit that referenced this pull request Sep 20, 2024
web-padawan added a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants