chore: use puppeteer launcher to run Chrome tests, bump Node to 18 (CP: 23.5) #7826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* test: use puppeteer launcher to run Chrome tests * chore: also use Puppeteer for snapshots and integration
web-padawan
changed the title
vursen
approved these changes
Sep 19, 2024
web-padawan
force-pushed
the
cp/puppeteer-launcher-23.5
branch
from
c3b686f
to
db85234
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry-pick of #7701 with changes from #7222 (switch to
headless: 'shell') and #7786.This would be needed to make Chrome builds pass when backporting fixes to
23.5branch.Type of change