fix: debounce an update after virtualizer size change #7400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivirkki
force-pushed
the
fix/virtualizer/subsequent-size-changes
branch
from
81153ad
to
a31cc02
Compare
tomivirkki
commented
May 10, 2024
packages/component-base/test/virtualizer-variable-row-height.test.js
Outdated
Show resolved
Hide resolved
tomivirkki
force-pushed
the
fix/virtualizer/subsequent-size-changes
branch
from
0d71743
to
5226900
Compare
|
web-padawan
approved these changes
May 13, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
May 13, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
May 13, 2024
tomivirkki
added a commit
that referenced
this pull request
May 13, 2024
Co-authored-by: Tomi Virkki <[email protected]>
tomivirkki
added a commit
that referenced
this pull request
May 14, 2024
….3) (#7405) Co-authored-by: Tomi Virkki <[email protected]>
|
This ticket/PR has been released with Vaadin 24.5.0.alpha1 and is also targeting the upcoming stable 24.5.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Schedule an update after Virtualizer size change to ensure item positions are correct after subsequent size change+update calls
Fixes vaadin/flow-components#6269
Type of change
Bugfix