-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dynamic route animation #646
Open
stefanholzapfel
wants to merge
8
commits into
vaadin:main
Choose a base branch
from
stefanholzapfel:master
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [rollup](https://github.com/rollup/rollup) from 2.35.1 to 2.52.2. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v2.35.1...v2.52.2) --- updated-dependencies: - dependency-name: rollup dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
… function returning a class string instead of string directly
… function returning a class string instead of string directly
… function returning a class string instead of string directly
… function returning a class string instead of string directly
… function returning a class string instead of string directly
# Conflicts: # src/router.js
|
stefanholzapfel
changed the title
Feature: Dynamic route animation
feat: Dynamic route animation
Jun 24, 2021
stefanholzapfel
changed the title
feat: Dynamic route animation
feat: dynamic route animation
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I needed different behaviour for my route animations, depending on the route the app is going to. E.g. components should leave to the left when going deeper in the routing tree, leaving right when going "back". The simplest way was to enable the router to accept a factory function for the "animate" property that would be evaluated on every route change.
The "animation" property now also accepts a function that returns the animation object:
animate: boolean | { enter: string, leave: string} | (from: HTMLElement, to: HTMLElement) => { enter: string, leave: string }
closes #845
Type of change
Checklist
Additional for
Feature
type of change