Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct service name #2666

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Use the correct service name #2666

wants to merge 3 commits into from

Conversation

Legioth
Copy link
Member

@Legioth Legioth commented Aug 20, 2024

No description provided.

@CLAassistant
Copy link

CLAassistant commented Aug 20, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.29%. Comparing base (d7c8b31) to head (f4bc799).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2666   +/-   ##
=======================================
  Coverage   92.29%   92.29%           
=======================================
  Files          76       76           
  Lines        2479     2479           
  Branches      643      643           
=======================================
  Hits         2288     2288           
  Misses        144      144           
  Partials       47       47           
Flag Coverage Δ
unittests 92.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@taefi
Copy link
Contributor

taefi commented Aug 20, 2024

Funny that since we moved to servlet 5, no one complained about this, so either:

  • No one is deploying a war package on a servlet container, or
  • The com.vaadin.hilla.startup.EndpointsValidator is loaded by Flow automatically since it is implementing com.vaadin.flow.server.startup.ClassLoaderAwareServletContainerInitializer - not sure that's the reason.

Then, the question is: Do we actually need it?
Anyway, this change doesn't harm anyone and should have been applied sooner.

@Legioth
Copy link
Member Author

Legioth commented Aug 21, 2024

Should maybe also be cherry picked to 24.4.x?

@taefi
Copy link
Contributor

taefi commented Aug 21, 2024

Should maybe also be cherry picked to 24.4.x?

At least to 24.4.
2.5 is also using the jakarta namespace.

Copy link

sonarcloud bot commented Sep 2, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants