Skip to content

Feat/dashboard style variants #7317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 22, 2025
Merged

Conversation

rolfsmeds
Copy link
Contributor

@rolfsmeds rolfsmeds commented Apr 15, 2025

Description

  • Elevated and Flat style variants
  • Shaded background variant for board itself

Fixes #8961

Continuation of vaadin/web-components#8962

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/pr
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.
  • I have not completed some of the steps above and my pull request can be closed immediately.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@rolfsmeds rolfsmeds requested a review from ugur-vaadin April 15, 2025 17:15
@ugur-vaadin ugur-vaadin force-pushed the feat/dashboard-style-variants branch 2 times, most recently from fdff18e to 4e0eae2 Compare May 22, 2025 09:24
@ugur-vaadin ugur-vaadin enabled auto-merge (squash) May 22, 2025 10:10
@ugur-vaadin ugur-vaadin force-pushed the feat/dashboard-style-variants branch from 27b3a08 to 2e6eed2 Compare May 22, 2025 10:41
Copy link

@ugur-vaadin ugur-vaadin merged commit ad6eb0d into main May 22, 2025
5 checks passed
@ugur-vaadin ugur-vaadin deleted the feat/dashboard-style-variants branch May 22, 2025 11:11
@vaadin-bot
Copy link
Collaborator

Hi @rolfsmeds and @ugur-vaadin, when i performed cherry-pick to this commit to 24.8, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick ad6eb0d
error: could not apply ad6eb0d... Feat/dashboard style variants (#7317)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

ugur-vaadin added a commit that referenced this pull request May 22, 2025
* Added DashboardVariant enum

* Added flat variant

* Finalized variants.

* Update vaadin-dashboard-flow-parent/vaadin-dashboard-flow/src/main/java/com/vaadin/flow/component/dashboard/DashboardVariant.java

Co-authored-by: Ugur Saglam <[email protected]>

* chore: run formatter

---------

Co-authored-by: Ugur Saglam <[email protected]>
Co-authored-by: ugur-vaadin <[email protected]>
web-padawan pushed a commit that referenced this pull request May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants