Skip to content

docs: add Grid Pagination chapter and examples #4274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 7, 2025

Conversation

bwajtr
Copy link
Contributor

@bwajtr bwajtr commented Apr 28, 2025

Added a chapter to the Grid documentation about the differences between Infinite Scrolling and Pagination.
Added pros and cons for both.
Also added Pagination implementation example in Flow, Lit and React. At the end the text is not that long, so I've decided to not add a new tab for this topic, but rather place it under Lazy Loading chapter

image

Copy link

github-actions bot commented Apr 28, 2025

AI Language Review

The main change in the document is the addition of a new section on Pagination. The content is well-structured, providing a clear distinction between infinite scrolling and pagination, along with guidance on how to implement manual pagination using Vaadin components. The section includes a concise explanation of the custom pagination implementation, ensuring it aligns with the existing documentation style.

No issues were introduced with this addition, and the document as a whole remains consistent and clear. The new content is precise, informative, and follows the documentation's established guidelines effectively.

@bwajtr bwajtr requested review from web-padawan and TatuLund May 2, 2025 15:18
Copy link
Contributor

@rolfsmeds rolfsmeds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well written, looks good. The only thing that bothers me a bit is that the full code samples for the solution are very long. Could consider splitting the pagination controls implementation into separate files, but that could also be a later refinement.

@bwajtr bwajtr merged commit 0918f68 into latest May 7, 2025
4 of 5 checks passed
@bwajtr bwajtr deleted the docs/grid-manual-pagination-example branch May 7, 2025 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants