Improve the query API of llm cache and use vector<uint8_t> as payload object. #1797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashanji
force-pushed
the
improve-query-api
branch
from
f013b4f to
1edb37c
Compare
dashanji
requested review from
vegetableysm and
sighingnow
and removed request for
vegetableysm
sighingnow
approved these changes
Mar 4, 2024
sighingnow
requested changes
Mar 4, 2024
sighingnow
requested changes
Mar 4, 2024
sighingnow
requested changes
Mar 4, 2024
| @@ -27,7 +27,7 @@ limitations under the License. | |||
|
|
|||
| using namespace vineyard; // NOLINT(build/namespaces) | |||
|
|
|||
| #define DIMENSION 100 | |||
| #define TENSORBYTES 800 | |||
| #define CAPACITY 1000 | |||
| #define LAYER 64 | |||
| #define BLOCK_SIZE 100 | |||
There was a problem hiding this comment.
Use constexpr int or constexpr size_t for constants in C++.
dashanji
force-pushed
the
improve-query-api
branch
2 times, most recently
from
114fe52 to
a359b88
Compare
sighingnow
requested changes
Mar 6, 2024
dashanji
force-pushed
the
improve-query-api
branch
4 times, most recently
from
663c7a5 to
ec2eab6
Compare
…ad object. * Replace the alias of KV_STATE_WITH_LAYER with std::map<int, std::pair<K_STATE, V_STATE>>. * Use the references of std::vector<T> to avoid copying. * Print the rax tree to a string for debugging. * Replace the alias of KV_STATE_WITH_LAYER with std::map<int, std::pair<K_STATE, V_STATE>>. * Rename the Dimension with TensorBytes. Signed-off-by: Ye Cao <[email protected]>
dashanji
force-pushed
the
improve-query-api
branch
from
ec2eab6 to
45acb82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
queryAPI, users only input a token list and will get the kv_cache with the longest prefix.DimensionwithTensorBytes.std::vector<T>to avoid copying.Related issue number
std::vector<T>andstd::shared_ptr<T>#1786vector<uint8_t>as payload object and remove all assumption about double #1795