Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Image] Docker run restart policy support #40

Merged
merged 10 commits into from
Jul 13, 2024
Merged

[Image] Docker run restart policy support #40

merged 10 commits into from
Jul 13, 2024

Conversation

omesser
Copy link
Contributor

@omesser omesser commented Jan 6, 2021 •
edited
Loading

  • Restart policy flags can now be defined as an Image property
  • Minor changes/fixes in tests
  • Added pycharm runConfigurations
  • Added some non default properties to test shell commands

@omesser omesser closed this Dec 9, 2021
@omesser omesser reopened this Dec 9, 2021
@omesser omesser force-pushed the restart_support branch 2 times, most recently from 41e506a to 3589c2a Compare February 19, 2024 16:51
@omesser omesser marked this pull request as draft February 23, 2024 00:32
liranbg
liranbg reviewed Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@liranbg liranbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finalizing this PR
minor comment to make it merge-ready

install Outdated Show resolved Hide resolved
@omesser omesser marked this pull request as ready for review July 13, 2024 15:31
@omesser
Copy link
Contributor Author

omesser commented Jul 13, 2024

forgot about that for a while, but finalized it now. will push for a PR adding a python version CI matrix next if you want @liranbg

@liranbg
Update pyproject.toml
87a93f7 
updated authors and unblocked 3.9 from being installed using manof
@liranbg liranbg changed the title Docker run restart policy support [Image] Docker run restart policy support Jul 13, 2024
@liranbg liranbg merged commit 9c5283a into v3io:development Jul 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liranbg liranbg liranbg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omesser @liranbg