Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if a message gets more than 5 of any reaction, not just stars, it will now be added to the starboard #191

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

oh-finks
Copy link

@oh-finks oh-finks commented Jan 5, 2024

What kind of change does this PR introduce?
(Bug fix, feature, docs update, ...)

Describe the changes proposed in the pull request
A quick description of the changes made to the repository

What is the current behavior?
(You can also link to an open issue here)

What is the new behavior
(if this is a feature change)?

Does this PR introduce a breaking change?
(What changes might users need to make in their application due to this PR?)

Does this PR introduce changes to the database?
(What has changed? Did you make sure to setup the create statements in __main__.py?)

Other information:

any reaction emoji can put something on the
starboard, not just stars.
Copy link
Contributor

@timelessnesses timelessnesses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs more opinions.
personally starboards is intentionally for keeping the amount of star reactions on a message then post it on starboard channel

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the entire purpose of starboard is keeping track of star reactions on message and NOT any reactions

@justinlime
Copy link
Contributor

Is this tested? Looks like this would add it to the board for ANY combinations of 5+ reactions, ideally they would be 5+ of the same reaction

@justinlime
Copy link
Contributor

needs more opinions.
personally starboards is intentionally for keeping the amount of star reactions on a message then post it on starboard channel

We discussed this in the discord, we thought it be better to have it more general

@oh-finks
Copy link
Author

oh-finks commented Jan 6, 2024

needs more opinions. personally starboards is intentionally for keeping the amount of star reactions on a message then post it on starboard channel

image

Copy link
Contributor

@xsnowstorm xsnowstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a bug which I have fixed here:
oh-finks#1

fixed bug where non-star reactions get ignored
@timelessnesses
Copy link
Contributor

ah okay

@logicguy1
Copy link
Collaborator

I think i still need to be convinced

@oh-finks
Copy link
Author

take it up with virbox himself

@jtbx
Copy link
Contributor

jtbx commented Jan 25, 2024

Some other servers such as the hyprland discord have this sort of functionality:

I think we should at least try it out and see what people think, we could have a poll later on to see if people want the old starboard behaviour back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants