Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppImage: fix variable syntax #6

Merged

Conversation

git-developer
Copy link
Contributor

No description provided.

@v1993
Copy link
Owner

v1993 commented Sep 10, 2023

This shouldn't be needed? The code in question is adapted directly from example in docs and uses a variable set by appimage builder itself.

Oh well, let's check what artifacts will be.

@v1993
Copy link
Owner

v1993 commented Sep 10, 2023

Aand it works. Sigh, can people at least test code before putting it into documentation?..

Or might be because of appimage-builder action using an outdated version of program.

dist/AppImageBuilder.yml Outdated Show resolved Hide resolved
@v1993 v1993 merged commit 13d5951 into v1993:appimage-no-integrate Sep 10, 2023
4 checks passed
@git-developer git-developer deleted the appimage-no-integrate branch September 10, 2023 15:25
@git-developer
Copy link
Contributor Author

Or might be because of appimage-builder action using an outdated version of program.

Yes, looks like build-appimage@v1 is not "latest v1" but "1.0". It was never updated. [email protected] uses appimage-builder:1.1.0, so maybe an update avoids issues like this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants