Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some problem #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix some problem #23

wants to merge 1 commit into from

Conversation

xiesc
Copy link

@xiesc xiesc commented Nov 15, 2021

Awesome project! I test the code on both x86 and arm(Xavier), when compiled on arm without neon, there is a bug that a variable named L should be level.
I also found that when formulating information matrix for velocity prior, the bottomRightCorner is miswritten by bottomLeftCorner.
And there are some information matrix is indeterminate, which will cause ComputationInfo::NumericalIssue in Eigen::LLT<information_t>. As result, I found that there are some times square_root_information_ is not computed as expectation. Adding a tiny value in information matrix can relax this problem, however, a custom LocalParameterization for this situation may be more appropriate.
pls check if these modifications is right.

…alue in information matrix to avoid indeterminate matrix in LLT decomposition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant