Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Awesome project! I test the code on both x86 and arm(Xavier), when compiled on arm without neon, there is a bug that a variable named
L
should belevel
.I also found that when formulating information matrix for velocity prior, the
bottomRightCorner
is miswritten bybottomLeftCorner
.And there are some information matrix is indeterminate, which will cause
ComputationInfo::NumericalIssue
inEigen::LLT<information_t>
. As result, I found that there are some timessquare_root_information_
is not computed as expectation. Adding a tiny value in information matrix can relax this problem, however, a customLocalParameterization
for this situation may be more appropriate.pls check if these modifications is right.