Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issv3 disable pages #9728

Open
wants to merge 5 commits into
base: issv3
Choose a base branch
from
Open

Issv3 disable pages #9728

wants to merge 5 commits into from

Conversation

mcalmer
Copy link
Contributor

@mcalmer mcalmer commented Feb 4, 2025

What does this PR change?

We need to disable some pages when we are a Hub

  • Admin => Setup Wizard => Organization Credentials
  • Admin => Setup Wizard => Products
  • Admin => Setup Wizard => Payg Connections

GUI diff

No difference.

Before:

After:

  • DONE

Documentation

  • Part of the ISSv2 docs

  • DONE

Test coverage

  • Unit tests were added

  • DONE

Links

Issue(s): https://github.com/SUSE/spacewalk/issues/25356

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

Copy link
Contributor

github-actions bot commented Feb 4, 2025

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕

You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/9728/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/9728/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Suggested tests to cover this Pull Request
  • srv_first_settings
  • srv_menu
  • allcli_sanity
  • srv_sync_channels
  • srv_enable_sync_products
  • srv_sync_products
  • min_custom_pkg_download_endpoint
  • srv_notifications
  • min_bootstrap_api
  • min_retracted_patches
  • allcli_software_channels
  • min_move_from_and_to_proxy
  • proxy_traditional_cobbler_pxeboot
  • allcli_config_channel
  • min_recurring_action
  • srv_change_task_schedule
  • srv_content_lifecycle
  • srv_create_fake_repositories
  • srv_mainpage
  • min_bootstrap_negative
  • srv_delete_channel_with_tool
  • srv_handle_software_channels_with_ISS_v2
  • min_salt_formulas
  • min_action_chain
  • srv_create_fake_channels
  • min_change_software_channel
  • srv_clone_channel_npn
  • srv_logfile
  • srv_dist_channel_mapping
  • srv_create_dev_channels
  • srv_channel_api
  • srv_cobbler_distro
  • minssh_action_chain
  • min_config_state_channel_api
  • min_ansible_control_node
  • min_config_state_channel
  • srv_manage_channels_page
  • buildhost_bootstrap
  • allcli_overview_systems_details
  • proxy_traditional_retail_pxeboot
  • min_rhlike_monitoring
  • minssh_bootstrap_api
  • srv_delete_channel_from_ui
  • buildhost_docker_build_image
  • buildhost_osimage_build_image
  • srv_patches_page
  • min_deblike_remote_command
  • min_bootstrap_reactivation
  • min_salt_mgrcompat_state
  • srv_menu_filter
  • proxy_container_cobbler_pxeboot
  • min_deblike_ssh
  • min_salt_minions_page
  • srv_sync_fake_channels
  • minssh_move_from_and_to_proxy
  • min_salt_lock_packages
  • min_bootstrap_ssh_key
  • min_salt_software_states
  • allcli_system_group
  • min_salt_minion_details
  • min_project_lotus
  • min_deblike_salt_install_package
  • srv_power_management
  • minssh_tunnel
  • min_salt_user_states
  • srv_disable_scheduled_reposync
  • sle_minion
  • allcli_action_chain
  • srv_cobbler_sync
  • min_salt_pkgset_beacon
  • srv_sync_dev_channels
  • min_rhlike_ssh
  • proxy_container_retail_mass_import
  • srv_reportdb
  • min_rhlike_salt
  • proxy_container
  • allcli_software_channels_dependencies
  • min_deblike_openscap_audit
  • sle_ssh_minion
  • min_rhlike_openscap_audit
  • min_empty_system_profiles
  • min_deblike_salt
  • srv_task_status_engine
  • min_monitoring
  • min_activationkey
  • minssh_ansible_control_node
  • srv_payg_ssh_connection
  • min_salt_openscap_audit
  • allcli_reboot
  • min_deblike_salt_install_with_staging
  • srv_maintenance_windows
  • srv_docker_cve_audit
  • min_salt_install_package
  • proxy_container_retail_pxeboot
  • srv_push_package
  • min_salt_formulas_advanced
  • buildhost_docker_auth_registry
  • min_timezone
  • minssh_salt_install_package
  • min_config_state_channel_subscriptions
  • min_rhlike_salt_install_package_and_patch
  • min_deblike_monitoring
  • srv_virtual_host_manager
  • min_salt_install_with_staging
  • min_cve_audit
  • min_check_patches_install
  • proxy_container_branch_network
  • srv_create_activationkey
  • srv_manage_activationkey
  • srv_user_configuration_salt_states
  • allcli_update_activationkeys

@mcalmer mcalmer changed the base branch from master to issv3 February 4, 2025 15:23
@mcalmer mcalmer force-pushed the issv3-disable-pages branch from b5b774d to a13666c Compare February 4, 2025 16:49
@mcalmer mcalmer force-pushed the issv3-disable-pages branch 3 times, most recently from 466c538 to f15dba4 Compare February 6, 2025 16:33
@mcalmer mcalmer force-pushed the issv3 branch 2 times, most recently from 54daf1f to b848faf Compare February 6, 2025 16:36
@mcalmer mcalmer force-pushed the issv3-disable-pages branch from f15dba4 to 8163b53 Compare February 6, 2025 16:38
@mcalmer mcalmer force-pushed the issv3-disable-pages branch from ab07cff to aefe14e Compare February 7, 2025 14:29
@mcalmer mcalmer marked this pull request as ready for review February 7, 2025 15:56
@mcalmer mcalmer requested review from a team as code owners February 7, 2025 15:56
@mcalmer mcalmer requested review from cbbayburt, lucidd, mackdk, Serp1co and CDellaGiusta and removed request for a team February 7, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants