Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin remove channel #1233500 #3631

Merged
merged 9 commits into from
Jan 23, 2025
Merged

Conversation

keichwa
Copy link
Contributor

@keichwa keichwa commented Jan 22, 2025

@keichwa
Copy link
Contributor Author

keichwa commented Jan 22, 2025

I did not a complete reorg (webui vs. cli). If needed or wanted, this could be done with a separate PR.

@keichwa keichwa requested review from 0rnela and jcayouette January 22, 2025 07:42
@keichwa keichwa marked this pull request as draft January 22, 2025 09:29
@keichwa keichwa marked this pull request as ready for review January 22, 2025 09:43
@keichwa keichwa requested review from 0rnela and mcalmer January 22, 2025 09:44
Copy link
Contributor

@mcalmer mcalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one open question. But I can approve already

Copy link
Contributor

@0rnela 0rnela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will approve following addressing of MC's comment.

@keichwa keichwa requested a review from 0rnela January 22, 2025 15:35
@keichwa keichwa merged commit 50e1658 into master Jan 23, 2025
1 check failed
@keichwa keichwa deleted the admin-remove-channel-#1233500-keichwa branch January 23, 2025 15:44
keichwa added a commit that referenced this pull request Jan 23, 2025
SUSE/spacewalk#25866
https://bugzilla.suse.com/show_bug.cgi?id=1233500

* drop workflow related mini sections and promote others
* delete section on fsck (per feedback)
* Update modules/administration/pages/removing-channels.adoc
Co-authored-by: Ornela Marić <[email protected]>
Co-authored-by: Michael Calmer <[email protected]>
keichwa added a commit that referenced this pull request Jan 27, 2025
SUSE/spacewalk#25866
https://bugzilla.suse.com/show_bug.cgi?id=1233500

* drop workflow related mini sections and promote others
* delete section on fsck (per feedback)
* Update modules/administration/pages/removing-channels.adoc

Co-authored-by: Ornela Marić <[email protected]>
Co-authored-by: Michael Calmer <[email protected]>
0rnela added a commit that referenced this pull request Jan 28, 2025
SUSE/spacewalk#25866
https://bugzilla.suse.com/show_bug.cgi?id=1233500

* drop workflow related mini sections and promote others
* delete section on fsck (per feedback)
* Update modules/administration/pages/removing-channels.adoc
Co-authored-by: Ornela Marić <[email protected]>
Co-authored-by: Michael Calmer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants