Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove quickstart jcayouette #3426

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Remove quickstart jcayouette #3426

wants to merge 4 commits into from

Conversation

jcayouette
Copy link
Contributor

Removes quickstart from both Uyuni and SUMA by commenting out the books in the params file. We can adjust the code for final removal in the future.

@jcayouette jcayouette self-assigned this Nov 11, 2024
keichwa
keichwa reviewed Nov 11, 2024
View reviewed changes
Copy link
Contributor

@keichwa keichwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog entry doesn't cover what you did ;) You removed the build targets and comment it in the book list. I think it would be good if you'd also remove the files, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keichwa keichwa keichwa left review comments

@0rnela 0rnela Awaiting requested review from 0rnela

Assignees

@jcayouette jcayouette

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcayouette @keichwa