Exclude openSUSE Leap Micro from avahi_pkg #1742
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agraul
reviewed
Oct 28, 2024
There was a problem hiding this comment.
Instead of specifying a list of names to skip, wouldn't it be easier to check grains.get("transactional")? I think that scales better.
P.S.: I'm aware we have been using the list of OS-names approach in many places, I think it would be good to slowly move away from that
|
What I'm currently missing is why we want to skip installing avahi. Is it pre-installed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
This PR avoid applying the
avahi_pkgstate on openSUSE Leap Micro.