-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't trigger repos salt states for a server on a transactional system #1740
Conversation
|
I remember that there could be issues when you reboot a system during a Salt state. Maybe we can do the reboot at the very end of Salt? |
I'm worry about the behavior on salt states after the action mentioned here:
As this will not take into account after a reboot, so next actions on salt states will not have this applied. (That's on snapshot 6, on the case we are trying to fix) |
364c060
to
3cd57cd
Compare
I changed the draft, so we don't run unnecessary salt states on the server if we are on a transactional system |
It seems to work without any issue:
|
3cd57cd
to
6616c25
Compare
What does this PR change?
This is just an attempt to fix the issue explained here:
https://github.com/SUSE/spacewalk/issues/25575#issuecomment-2426285245
-
at snapshot 5 means currently running snapshot.+
at snapshot 7 means what will be active on new boot.I would like the help of Ion Squad to fix it properly.
Handling a reboot on salt states can be quite delicate, and from what I could see, we don't really need the salt states generating snapshots 6 and 7