Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore TBB_FILE_TRIM option for Intel compiler #1610

Merged
merged 5 commits into from
Jan 21, 2025

Conversation

omalyshe
Copy link
Contributor

@omalyshe omalyshe commented Jan 20, 2025

Description

Intel compiler on Windows doesn't support /d1trimfile option that causes test compilation failure.

Fixes # - issue number(s) if exists

Type of change

Choose one or multiple, leave empty if none of the other choices apply

Add a respective label(s) to PR if you have permissions

  • bug fix - change that fixes an issue
  • new feature - change that adds functionality
  • tests - change in tests
  • infrastructure - change in infrastructure and CI
  • documentation - documentation update

Tests

  • added - required for new features and some bug fixes
  • not needed

Documentation

  • updated in # - add PR number
  • needs to be updated
  • not needed

Breaks backward compatibility

  • Yes
  • No
  • Unknown

Notify the following users

@xufang-lisa

Other information

@omalyshe omalyshe requested review from dnmokhov and isaevil January 20, 2025 21:08
Copy link
Contributor

@isaevil isaevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@omalyshe omalyshe merged commit 8dea30c into master Jan 21, 2025
26 checks passed
@omalyshe omalyshe deleted the dev/omalyshe/fix-win-icx-build branch January 21, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants