Simplify fence usage in radix sort #2057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyKopienko
requested review from
dmitriy-sobolev,
danhoeflinger,
akukanov,
MikeDvorskiy,
adamfidel and
mmichel11
SergeyKopienko
force-pushed
the
dev/skopienko/simplify_fence_usage_in_radix_sort
branch
from
338eb0c to
0103049
Compare
dmitriy-sobolev
force-pushed
the
dev/dmitriy-sobolev/radix-fix
branch
from
bb31221 to
affaabe
Compare
…_one_wg.h - simplify fence usage in radix sort
…_one_wg.h - fix compile error: __fence_space_local, __fence_space_global and __fence_space_global_and_local are not declared as device-copyable
…_one_wg.h - declare _TempBuf::get_fence() as non-static and constexpr
…dix_sort_one_wg.h - declare _TempBuf::get_fence() as non-static and constexpr" This reverts commit 0103049.
SergeyKopienko
force-pushed
the
dev/skopienko/simplify_fence_usage_in_radix_sort
branch
from
898ab4b to
aab5be5
Compare
include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl_radix_sort_one_wg.h
Outdated
Show resolved
Hide resolved
include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl_radix_sort_one_wg.h
Outdated
Show resolved
Hide resolved
…ix_sort_one_wg.h Co-authored-by: Dmitriy Sobolev <[email protected]>
…ix_sort_one_wg.h Co-authored-by: Dmitriy Sobolev <[email protected]>
dmitriy-sobolev
approved these changes
Feb 10, 2025
dmitriy-sobolev
deleted the
dev/skopienko/simplify_fence_usage_in_radix_sort
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I this PR I made some simplification of
fenceusage for the PR #2054 :radix_sortimplementation.