-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC Move histogram CPU backend implementation to Supported #2015
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Dan Hoeflinger <[email protected]>
Reminder to myself that I need to address #1974 (comment) |
It would also be good to add the library version macro, specification macro and/or feature macro values which indicate if the feature is supported. You might as well mention that value for the device policies. Any potential future improvements can be mentioned as well. |
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Co-authored-by: Alexey Kukanov <[email protected]>
@akukanov Thanks, the edits are good and have applied your suggestions. |
…age type. Signed-off-by: Dan Hoeflinger <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The introduction can perhaps be updated as well.
### Version Information | ||
Histogram APIs are supported for host execution policies as of version 2022.8.0 of oneDPL, specification version 1.4. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great to found the version information easily at the beginning of the document.
Also I would move up the chapter describing the implementation above the thoughts on alternatives, which are now mostly of historical interest.
Move histogram CPU backend implementation to supported.
No changes to content so far, pending implementation PR.
This should be merged once histogram implementation has been merged. #1974