Making locks_leader pass locks-test #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref. https://github.com/ten0s/locks-test Fixes include adding an election ref value, to sync with cands. This value is kept when the leader enters the safe loop. Also, an 'assert_leader' message is introduced, to ensure that candidates are kicked out of the safe loop when a leader acquires a new lock and remains the leader. Also, a locks_agent:async_await_all_locks/1 function was added to ensure that the leader gets told that it has all locks in a contested scenario.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. https://github.com/ten0s/locks-test (see issue #30 )
Fixes include adding an election ref value, to sync with cands.
This value is kept when the leader enters the safe loop.
Also, an 'assert_leader' message is introduced, to ensure that
candidates are kicked out of the safe loop when a leader acquires
a new lock and remains the leader.
Also, a locks_agent:async_await_all_locks/1 function was added
to ensure that the leader gets told that it has all locks in a
contested scenario.