Add assertion

uweseimet · Jan 27, 2025 · a624009 · a624009
1 parent c5235ba
commit a624009
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 7 deletions.
diff --git a/cpp/s2p/s2p_server.cpp b/cpp/s2p/s2p_server.cpp
@@ -19,10 +19,7 @@ using namespace spdlog;
 string S2pServer::Init(int port)
 {
     assert(server_socket == -1);
-
-    if (port <= 0 || port > 65535) {
-        return fmt::format("Invalid port number: {}", port);
-    }
+    assert(port > 0 && port <= 65535);
 
     server_socket = socket(PF_INET, SOCK_STREAM, 0);
     if (server_socket == -1) {

diff --git a/cpp/test/s2p_thread_test.cpp b/cpp/test/s2p_thread_test.cpp
@@ -43,9 +43,6 @@ TEST(S2pThreadTest, Init)
 {
     S2pThread service_thread;
 
-    EXPECT_FALSE(service_thread.Init(65536,nullptr, default_logger()).empty()) << "Illegal port number";
-    EXPECT_FALSE(service_thread.Init(0, nullptr, default_logger()).empty()) << "Illegal port number";
-    EXPECT_FALSE(service_thread.Init(-1, nullptr, default_logger()).empty()) << "Illegal port number";
     EXPECT_TRUE(service_thread.Init(9999, nullptr,default_logger()).empty())
         << "Port 9999 is expected not to be in use for this test";
     service_thread.Stop();