Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering fix #236

Merged
merged 3 commits into from
Feb 7, 2024
Merged

Filtering fix #236

merged 3 commits into from
Feb 7, 2024

Conversation

connor-bechthold
Copy link
Collaborator

Notion task link

N/A

Implementation description

  • The precedence of logical operations was incorrect when certain filters were applied to log records
  • This was fixed with some 🔥🔥🔥🔥🔥 brackets 🔥🔥🔥🔥🔥

Steps to test

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR
  • If I have made API changes, I have updated the REST API Docs
  • IF I have made changes to the db/models, I have updated the Data Models Page
  • I have documented this PR in the Production Release Page
  • I have updated other Docs as needed

Copy link

github-actions bot commented Feb 7, 2024

Visit the preview URL for this PR (updated for commit 86be742):

https://blueprintsupportivehousing--pr236-connor-fix-filtering-8goo3ds9.web.app

(expires Wed, 14 Feb 2024 07:30:56 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f6bcdba7452bf82a6ec1a299c37d1bdff7870d09

@connor-bechthold connor-bechthold merged commit 6ddbf35 into main Feb 7, 2024
2 checks passed
@connor-bechthold connor-bechthold deleted the connor/fix-filtering branch February 7, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant