Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TwoFa revamp #226

Merged
merged 1 commit into from
Jan 25, 2024
Merged

TwoFa revamp #226

merged 1 commit into from
Jan 25, 2024

Conversation

connor-bechthold
Copy link
Collaborator

Notion task link

N/A

Implementation description

  • Authy was discontinued, so a new authenticator application was used
  • https://authenticator.cc/ allows the same functionality for no extra charge
  • This is combined in the pyotp (Python One Time Password) library to create an identical solution with an easier setup

Steps to test

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR
  • If I have made API changes, I have updated the REST API Docs
  • IF I have made changes to the db/models, I have updated the Data Models Page
  • I have documented this PR in the Production Release Page
  • I have updated other Docs as needed

Copy link

Visit the preview URL for this PR (updated for commit 272f1c0):

https://blueprintsupportivehousing--pr226-connor-two-fa-revamp-vn2co1ka.web.app

(expires Thu, 01 Feb 2024 00:12:08 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f6bcdba7452bf82a6ec1a299c37d1bdff7870d09

@connor-bechthold connor-bechthold merged commit 26943e2 into main Jan 25, 2024
3 checks passed
@connor-bechthold connor-bechthold deleted the connor/two-fa-revamp branch January 25, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant