Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note, Tags, and Residents Column Formatting #208

Merged
merged 6 commits into from
Dec 3, 2023
Merged

Conversation

owen-sellner
Copy link
Contributor

@owen-sellner owen-sellner commented Nov 25, 2023

Notion task link

Notes Column Limitation
Tags Column
Residents Column Limitation

Implementation description

  • Added formatting functions to LogRecordsTable.tsx
  • Added extra null check in EditLog.tsx because of a TypeScript/eslint issue
  • Fixed bug with table header where the options button overlapped the heading by adding a z-index value to tableStyles.tsx

Steps to test

  1. Create new log records with 1 resident, 2 residents, 3 residents, and 4 residents
  2. Create new log records with a note less than 150 characters and one greater than 150 characters
  3. Create new log records with 1 tag, 2 tags, 3 tags, and 4 tags
  4. Check that formatting for note, tags, and residents is correct

What should reviewers focus on?

  • How many characters should be shown for the note?

Screenshot

image

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR
  • If I have made API changes, I have updated the REST API Docs
  • IF I have made changes to the db/models, I have updated the Data Models Page
  • I have documented this PR in the Production Release Page
  • I have updated other Docs as needed

Copy link

github-actions bot commented Nov 25, 2023

Visit the preview URL for this PR (updated for commit 6643a52):

https://blueprintsupportivehousing--pr208-owen-tags-column-j0i2cdc6.web.app

(expires Sun, 10 Dec 2023 20:57:44 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f6bcdba7452bf82a6ec1a299c37d1bdff7870d09

@owen-sellner owen-sellner marked this pull request as ready for review November 25, 2023 22:21
Copy link
Collaborator

@connor-bechthold connor-bechthold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I noticed the zIndex change may not have worked as intended:
Screenshot 2023-12-02 at 8 38 52 PM

Left a couple other small comments but otherwise really well done!!

frontend/src/components/forms/EditLog.tsx Show resolved Hide resolved
frontend/src/components/pages/HomePage/LogRecordsTable.tsx Outdated Show resolved Hide resolved
frontend/src/components/pages/HomePage/LogRecordsTable.tsx Outdated Show resolved Hide resolved
frontend/src/components/pages/HomePage/LogRecordsTable.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@phamkelly17 phamkelly17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a bug though l.o.l

Copy link
Collaborator

@connor-bechthold connor-bechthold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beauty

@owen-sellner owen-sellner merged commit 8bbe00b into main Dec 3, 2023
3 checks passed
@owen-sellner owen-sellner deleted the owen/tags-column branch December 3, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants