Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code for calendar event retrieval and ICS generation #59

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ColinToft
Copy link

@ColinToft ColinToft commented Feb 5, 2025

Notion ticket link

N/A

Ticket Name

Implementation description

  • Moves some functions around that are common to calendar/ics file generation
  • No functional change

Steps to test

  1. Make sure calendar (/calendar) still works and shows events
  2. Make sure ics file download (/ics) still works

What should reviewers focus on?

  • Let me know if this structure is reasonable (I'm not sure where to place common files in a next.js repo)

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sistema ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 2:02am

@ColinToft ColinToft force-pushed the colin/calendar-api-changes branch from 2a2dcdd to 5ef0bfa Compare February 5, 2025 02:01
@ColinToft ColinToft requested review from ChinemeremChigbo, a team and daniel-su1 and removed request for a team February 5, 2025 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant