-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style login page #34
Style login page #34
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hey! I don't think I have much to add to the review aside from what Chinemerem wrote. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make the suggested changes prior to merging. Also, after you successfully address a comment you should mark it as resolved.
Co-authored-by: Chinemerem <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review.
Thank you for the amazing work!!
Notion ticket link
Login Page
Implementation description
SistemaLogoColour
componentindex.tsx
SignInButton
componentSignOutButton
andsession
fromindex.tsx
Steps to test
Desktop Browser UI:
![Screenshot 2024-10-08 221117](https://private-user-images.githubusercontent.com/148646829/374779355-c4b46b8e-eabc-4633-a77d-8744b6f3546b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1Mzg5MzEsIm5iZiI6MTczOTUzODYzMSwicGF0aCI6Ii8xNDg2NDY4MjkvMzc0Nzc5MzU1LWM0YjQ2YjhlLWVhYmMtNDYzMy1hNzdkLTg3NDRiNmYzNTQ2Yi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNFQxMzEwMzFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02NDgxYWIxZjdlZDYyYjQ3MmQ1NDJiNmIyYzZmYTQ2ODVhMjEyOTBjMzE0OTI1NWZkOTBkNzgzZDU5YmU4YjRkJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.OozKkpcoB59KZ8kkpiNMtbOvoX5xealQsAutuaZBKJI)
(Dev Tool) Tablet UI:
![Screenshot 2024-10-08 222420](https://private-user-images.githubusercontent.com/148646829/374777125-cc0a537e-1098-4a0a-a3a4-2b080c4fcfbc.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1Mzg5MzEsIm5iZiI6MTczOTUzODYzMSwicGF0aCI6Ii8xNDg2NDY4MjkvMzc0Nzc3MTI1LWNjMGE1MzdlLTEwOTgtNGEwYS1hM2E0LTJiMDgwYzRmY2ZiYy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNFQxMzEwMzFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03ZTQzNWQ1OGFhMTc0YjllMzlkZmM0ZWIwODk0ZmYzZTdiYTVhYmQxMTM0ZThhOTQ2MjA4YmIxZDc3MjQ0YzAzJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.Vikoui02XKBRfQaKzqBtviOZTDlHtLTnoBBAOkTT7xE)
(Dev Tool) iPhone SE UI:
![Screenshot 2024-10-08 222501](https://private-user-images.githubusercontent.com/148646829/374777162-950f604e-5b43-4f12-9101-864b6f1d9a5b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1Mzg5MzEsIm5iZiI6MTczOTUzODYzMSwicGF0aCI6Ii8xNDg2NDY4MjkvMzc0Nzc3MTYyLTk1MGY2MDRlLTViNDMtNGYxMi05MTAxLTg2NGI2ZjFkOWE1Yi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNFQxMzEwMzFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1iMWZiMzFmYjE5ZDZmYTkxODVjMmFiMDAzNWI0NWZlNmJjN2RkMTI1YzJmZjRkN2Q0ZDU0MTA5Y2I0NmEwYjczJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.Hw00yKSgSPnhzGHo9unI7Ejl6csLb0mWAbiI_YEmFDo)
What should reviewers focus on?
UI alignment with mock
![screenshot_2024-10-01_at_9 21 19___pm](https://private-user-images.githubusercontent.com/148646829/374777290-60a98087-a4ab-43c1-baea-1a474dfe818c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1Mzg5MzEsIm5iZiI6MTczOTUzODYzMSwicGF0aCI6Ii8xNDg2NDY4MjkvMzc0Nzc3MjkwLTYwYTk4MDg3LWE0YWItNDNjMS1iYWVhLTFhNDc0ZGZlODE4Yy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNFQxMzEwMzFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0yMzRkOWFiZmU2NDQ0NGZmYWM4Nzc3MmNiMjVmYzY4MDllNmQzZGU2MzA3ZWJjODc2MzUxNDdkZDUyMWJmNjQzJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.wSg2PeW6Or0WNpWkFC4WbXpoYLyp9SSJPUx0fmyfKbc)
UI transferability (different screen sizes, orientations, etc.)
General code style/best practices
Checklist