Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carolyn/signup page #81

Merged
merged 12 commits into from
Dec 26, 2024
Merged

Carolyn/signup page #81

merged 12 commits into from
Dec 26, 2024

Conversation

carolynzhang18
Copy link
Collaborator

@carolynzhang18 carolynzhang18 commented Nov 21, 2024

Notion ticket link

Welcome/Login/Signup Page Design Implementation

Implementation description

  • Implemented designs for the welcome page (/welcome)
  • Implemented designs for side drawers (no error handling)
    • Admin login
      • Info text after clicking "Don't Have and Account?"
    • Facilitator login
  • Implemented designs for sign up components (/signup) (no error handling)

Figma Design:
https://www.figma.com/design/BVjAeCcvNSYMyaf9Vd9T6M/Early-Stages-(S24)?node-id=299-5521&t=5tCNi804SCHj8iJd-1

Go to --- DEV HANDOFF --- > Login

Steps to test

Test case 1: Login functionality still works

Test case 2: Facilitator sign up functionality still works

Test case 3: All links/url directs to proper page

Below are the implemented links:

  • Facilitator sign up from /welcome page directs to /signUp page
  • Facilitator sign up from facilitator login side drawer directs to /signUp page
  • Clicking "Already Have an Account" from /signUp page redirects to /welcome page with facilitator login side drawer open
  • Clicking any "Forgot Password" text leads to /forgot-password` page

What should reviewers focus on?

  • Design is accurately implemented
  • Implementation does not break with various screen sizes

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@carolynzhang18 carolynzhang18 mentioned this pull request Nov 21, 2024
4 tasks
Copy link

Visit the preview URL for this PR (updated for commit 3fd0604):

https://extendafamily-7613e--pr81-carolyn-signup-page-ltp95fdy.web.app

(expires Thu, 02 Jan 2025 17:05:46 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f8bb7b5cd838ab636347dc54fd0ab08ab3715d31

@carolynzhang18 carolynzhang18 merged commit b0e5540 into main Dec 26, 2024
3 checks passed
@carolynzhang18 carolynzhang18 deleted the carolyn/signup-page branch December 26, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants