Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signup Routing #33

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Signup Routing #33

merged 2 commits into from
Jun 19, 2024

Conversation

cherryyng
Copy link
Collaborator

@cherryyng cherryyng commented Jun 14, 2024

Notion ticket link

Signup Routing

Implementation description

  • Updated the signup page to only allow facilitator role URL
  • Implemented redirection to /welcome for unsupported roles
  • Extraction of role from frontend to backend through API Client

Steps to test

  1. Navigate to /signup?role=facilitator and check the page title is “Facilitator Signup”.
  2. Try accessing /signup with other roles (e.g., /signup?role=admin or /signup) and ensure it redirects to /welcome.
  3. Ensure a new user with the "Facilitator" role is added to the users collection when signing up.

What should reviewers focus on?

  • Ensure role extraction and backend passing are correct.
  • Verify redirection logic for unsupported roles works.

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

Copy link
Collaborator

@achandrabalan achandrabalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

image

@carolynzhang18 carolynzhang18 force-pushed the cherry/signup-routing branch from b19bd9b to ede7d9f Compare June 18, 2024 23:51
@cherryyng cherryyng force-pushed the cherry/signup-routing branch from ede7d9f to b19bd9b Compare June 19, 2024 00:05
@carolynzhang18 carolynzhang18 force-pushed the cherry/signup-routing branch from b19bd9b to ac89008 Compare June 19, 2024 00:15
Copy link
Collaborator

@carolynzhang18 carolynzhang18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 🤩🤩🤩

@cherryyng cherryyng merged commit 64b0b1c into main Jun 19, 2024
1 check passed
@cherryyng cherryyng deleted the cherry/signup-routing branch July 17, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants