-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add query params for roles in login page #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!! Everything works as expected, thanks for making those fixes!!! 😎
setAuthenticatedUser(user); | ||
}; | ||
|
||
const onSignupClick = () => { | ||
history.push(SIGNUP_PAGE); | ||
history.push(`${SIGNUP_PAGE}?role=${role}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
u are awesome for thinking ahead on this thank u!!
Everything looks good! All the testing worked as expected! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Notion ticket link
Ticket Name
Implementation description
Steps to test
What should reviewers focus on?
Checklist