Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broke "User" into three distinct roles #22

Merged
merged 2 commits into from
Jun 5, 2024
Merged

broke "User" into three distinct roles #22

merged 2 commits into from
Jun 5, 2024

Conversation

harishan-r
Copy link
Collaborator

Notion ticket link

User Roles

Implementation description

  • changed all occurrences of "User" to the three new User types.
  • Ensured that it is still storing a new user in users table*

Steps to test

  1. create a new user
  2. verify that it is in the user table with the "facilitator" role instead of "user" role

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR
  • - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ] - [ ]

@harishan-r harishan-r requested a review from carolynzhang18 June 5, 2024 00:40
Copy link
Collaborator

@carolynzhang18 carolynzhang18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 🔥🔥

@shanccui shanccui self-requested a review June 5, 2024 01:19
Copy link
Collaborator

@shanccui shanccui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good :)

@harishan-r harishan-r merged commit 61ec329 into main Jun 5, 2024
1 of 2 checks passed
@harishan-r harishan-r deleted the changeUserRoles branch June 5, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants