SD Card Logger + Library #338
Conversation
…9_fw_103_hw_brendan
There was a problem hiding this comment.
I think these should all be removed
| ******************************************************************************* | ||
| * @attention | ||
| * | ||
| * COPYRIGHT(c) 2016 STMicroelectronics |
There was a problem hiding this comment.
Is this using something from the HAL?
There was a problem hiding this comment.
Not sure what exactly the HAL is, could you clarify? Also, that line above seems to be added by scons format.
| s = prv_read_byte(spi, &readvalue); | ||
| if (s != STATUS_CODE_OK) return s; | ||
| if (--timeout) | ||
| return status_msg( |
There was a problem hiding this comment.
Sorry I might not be familiar with the source of some of this code - where is this status_msg type coming from? looks like this function is still supposed to be returning our StatusCode
There was a problem hiding this comment.
Not sure either. The old SD card program which this was based off of seemed to use it, and it expanded into a macro which returned a Status Code as normal. Maybe it returns a status code and also logs a message at the same time?
| frame[5] = (uint8_t)0x95; // CRC for a CMD0. We can hardcode this since the CRC is ignored from | ||
| // then on anyways. | ||
|
|
||
| spi_cs_set_state(spi, GPIO_STATE_LOW); |
There was a problem hiding this comment.
Is this not taken care of within spi_tx? If there is a reason this is here then leave a comment about it
There was a problem hiding this comment.
Don't actually think there's a reason for that to be there, I remember spi_tx does pull down. I think I could remove it.
|
|
||
| // Send CMD0 (SD_CMD_GO_IDLE_STATE) to put SD in SPI mode and | ||
| // wait for In Idle State Response (R1 Format) equal to 0x01 | ||
| do { |
There was a problem hiding this comment.
Kind of an interesting setup you've got with the do while loops, did you reference this from somewhere or is it just a fitting solution given that you need to send once and continue on some condition?
There was a problem hiding this comment.
It just seemed fitting since every step requires an initial try of the process, so I thought do-while would work for that
There was a problem hiding this comment.
This is super cool! Looks like a fairly simple interface and great job getting this to work I know it's a tough driver. Only note for this is maybe remove the mallocs and statically allocate so someone could copy paste your code into their project to test.
|
|
||
| // set spi CS state HIGH | ||
| gpio_set_state(&s_port[spi].cs, GPIO_STATE_HIGH); | ||
| StatusCode spi_cs_set_state(SpiPort spi, GpioState state) { |
There was a problem hiding this comment.
Oh I see I left a comment below about this, I think a comment would still help though
|
One more thing, for this project more than others please fill out the Readme with all the resources you used to write the driver. This one has some quirks so if there's no documentation it'll get out of date pretty quickly |
sd_binary.cis the file which defines general-purpose methods for reading and writing to the SD card.main.cis the smoke test file (need help writing this probably).