Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PD fault module #243

Merged
merged 7 commits into from
Jan 8, 2024
Merged

Conversation

elbertchen1
Copy link
Contributor

No description provided.

projects/power_distribution/src/pd_fault.c Outdated Show resolved Hide resolved
projects/power_distribution/inc/pd_fault.h Outdated Show resolved Hide resolved
projects/power_distribution/src/pd_fault.c Outdated Show resolved Hide resolved
projects/power_distribution/src/pd_fault.c Outdated Show resolved Hide resolved
projects/power_distribution/src/pd_fault.c Show resolved Hide resolved
projects/power_distribution/src/pd_fault.c Show resolved Hide resolved
projects/power_distribution/inc/pd_hw.h Outdated Show resolved Hide resolved
Copy link
Collaborator

@mitchellostler mitchellostler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! a few comments, and a change needed after a quick discussion with forest, that the threshold monitoring with the ADC can be removed

projects/power_distribution/src/main.c Outdated Show resolved Hide resolved
projects/power_distribution/src/pd_fault.c Outdated Show resolved Hide resolved
projects/power_distribution/src/pd_fault.c Outdated Show resolved Hide resolved
projects/power_distribution/inc/pin_defs.h Outdated Show resolved Hide resolved
projects/power_distribution/src/pd_fault.c Outdated Show resolved Hide resolved
@mitchellostler mitchellostler merged commit 23b2a16 into main Jan 8, 2024
1 check passed
@mitchellostler mitchellostler deleted the FWXV-251-pd-sense-t-v-c-monitoring branch January 8, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants