[FWXV 246] Added Files for Review #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchellostler
requested changes
Jan 3, 2024
bps_indicator.h
Outdated
| @@ -0,0 +1,15 @@ | |||
| #ifndef BPS_INDICATOR_H | |||
There was a problem hiding this comment.
We use #pragma once instead of #ifndef for our header files
bps_indicator.h
Outdated
| #include "outputs.h" | ||
|
|
||
| // callback function to periodically toggle the state of the bps fault indicator | ||
| static void prv_callback(); |
There was a problem hiding this comment.
static functions should not be in header files.
bps_indicator.h
Outdated
| static void prv_callback(); | ||
|
|
||
| // functions to start/stop bps fault indicator | ||
| static void start_bps_fault_indicator(); |
There was a problem hiding this comment.
Instead of leaving the brackets empty in these methods, it's better to use the void keyword. We also need to remove the static keyword here.
bps_indicator.c
Outdated
|
|
||
| static void stop_bps_fault_indicator() { | ||
| s_bps_fault_enabled = false; | ||
| soft_timer_cancel(&s_bps_indicator_timer); |
There was a problem hiding this comment.
nit: fix the indent.
Also, we don't need this cancel method, since we want the callback to be called a final time to turn off the hazard lights
mitchellostler
approved these changes
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added files for review for my first task, please let me know of any issues/points to fix!