Feature/comportdetection #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/EBEAM_dashboard into feature/comportdetection
…status of the avavilbe comports change
|
Oh, keep in mind that when this branch is merged into develop you will have to remove usr/com_ports.json so the handle the new format. |
|
This looks pretty solid. I think we first have to clean this branch so that we're not merging outdated G9Driversim changes into develop. Makes it hard to review the detection/config storages changes in isolation. the easiest way might be:
but if there's too much dependency, then we could wait for the G9 branch to be merged to develop, then rebase this on the updated develop. Also need an attachment of the log file |
…ons does not set all indicators to red
…n works with the threading of the G9
mslaffin
reviewed
Nov 18, 2024
mslaffin
force-pushed
the
feature/comportdetection
branch
from
234ff2f to
295fc13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have tested to make sure this works in all expected cases with the G9.
On a side note, the error/alarm red flashing light turns off once the connection is reestablished, sorry Brandon.
Will need to add the functionality for the VTRX subsystem and the Cathode Heating.
This does include a lot of the G9 branch files, let me know if I should remove them from this pull request