MUWM-5272: return 404 if no data

myuw/dao/textbook.py

@@ -36,4 +36,4 @@ def get_iacourse_status(request, term):
     key = "{}{}".format(term.quarter, term.year)
     if key in terms_iacourses:
         return terms_iacourses.get(key)
-    return {}
+    return None

myuw/test/api/test_textbook.py

@@ -89,9 +89,7 @@ def test_digital_material_api(self):
             'myuw_iacourse_digital_material_api',
             kwargs={'year': 2013,
                     'quarter': 'winter'})
-        self.assertEquals(response.status_code, 200)
-        data = json.loads(response.content)
-        self.assertIsNone(data)
+        self.assertEquals(response.status_code, 404)
 
         self.set_user('jbothell')
         response = self.get_response_by_reverse(
@@ -115,3 +113,7 @@ def test_get_payment_quarter(self):
         request = get_request_with_date('2013-09-19')
         q = get_payment_quarter(request)
         self.assertEquals(q.quarter, "autumn")
+
+        request = get_request_with_date('2013-12-27')
+        q = get_payment_quarter(request)
+        self.assertEquals(q.quarter, "winter")

myuw/test/dao/test_textbook.py

@@ -77,4 +77,4 @@ def test_get_iacourse_status(self):
             'javerage', get_request_with_date("2013-12-31"))
         term = get_current_quarter(req)
         data = get_iacourse_status(req, term)
-        self.assertEqual(data, {})
+        self.assertIsNone(data)

myuw/views/api/textbook.py

@@ -16,7 +16,7 @@
 from myuw.logger.logresp import log_api_call
 from myuw.views import prefetch_resources
 from myuw.views.api import ProtectedAPI
-from myuw.views.error import handle_exception
+from myuw.views.error import handle_exception, data_not_found
 
 logger = logging.getLogger(__name__)
 
@@ -145,6 +145,8 @@ def get(self, request, *args, **kwargs):
         try:
             ret_obj = get_iacourse_status(
                 request, get_payment_quarter(request))
+            if ret_obj is None:
+                return data_not_found()
             return self.json_response(ret_obj.json_data())
         except Exception:
             return handle_exception(logger, timer, traceback)

myuw_vue/components/accounts/tuition-fees.vue

@@ -345,9 +345,7 @@ export default {
       return this.tuition.pce_accbalance;
     },
     hasIacData() {
-      return (
-        this.isIacReady && this.iacData && 
-        this.iacData.ia_courses && this.iacData.ia_courses);
+      return this.isIacReady && this.iacData;
     },
     dayOneAccessDueDateFromNow() {
       return this.toFromNowDate(this.iacData.payment_due_day);