Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency ubuntu to v22 #49

Closed
wants to merge 2 commits into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 3, 2024

Mend Renovate

This PR contains the following updates:

Package Type Update Change
ubuntu github-runner major 20.04 -> 22.04

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.50%. Comparing base (61314ea) to head (169bc14).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #49   +/-   ##
=======================================
  Coverage   75.50%   75.50%           
=======================================
  Files          10       10           
  Lines        2935     2935           
  Branches      745      746    +1     
=======================================
  Hits         2216     2216           
  Misses        547      547           
  Partials      172      172           
Flag Coverage Δ
macos_latest 76.21% <ø> (ø)
ubuntu_latest 75.42% <ø> (ø)
windows_latest 15.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oSoMoN
Copy link
Collaborator

oSoMoN commented Apr 4, 2024

cargo dist seems to be expecting "ubuntu-20.04". According to the documentation, this can be customized in Cargo.toml.

Copy link
Contributor Author

renovate bot commented Apr 4, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@oSoMoN oSoMoN force-pushed the renovate/ubuntu-22.x branch from cd6bf17 to f400280 Compare April 23, 2024 16:48
@oSoMoN oSoMoN force-pushed the renovate/ubuntu-22.x branch from f400280 to 169bc14 Compare April 30, 2024 16:48
@oSoMoN
Copy link
Collaborator

oSoMoN commented Apr 30, 2024

According to cargo dist's documentation, the changes in 169bc14 should allow overriding the default runner. But the cargo dist plan call still complains.

Looking into why cargo dist defaults to Ubuntu 20.04, according to axodotdev/cargo-dist#749:

So we do hardcode to the oldest possible runner we can find specifically to link against the oldest possible libraries. In particular we want to link against the oldest possible glibc, so that the linux-gnu binaries are as portable as possible (for instance, iirc github codespaces defaults to running on 20.04, so binaries built on 22.04 fail to run there 😭).

So I suppose it makes sense to run with Ubuntu 20.04 images when creating releases. I'm therefore closing this PR.

@oSoMoN oSoMoN closed this Apr 30, 2024
@oSoMoN oSoMoN mentioned this pull request Apr 30, 2024
1 task
@renovate renovate bot deleted the renovate/ubuntu-22.x branch April 30, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant