-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update obsolete OS icons/logo #6196
base: main
Are you sure you want to change the base?
Conversation
The old logo for windows9x is visually better than the proposed. |
@tifasoftware I did think so too. Any other changes you would suggest? |
Thanks for doing these. However, could you double-check that the aspect ratio is correct for each new icon (i.e. not horizontally/vertically squished/stretched)? At least these looked slightly off to me, but please triple-check every icon:
|
I don’t understand this comment. Surely the right thing to do is to use whatever the correct official logo is/was, rather than critique which logo is somehow "better"? |
@rxhfcy I went back and checked, and you are right. Some of the photos did seem squished so I am redoing them to make sure the original aspect ratio is intact while fitting in a 128px square. With regards to fuzziness, I downloaded most of the PNGs from the distros official websites, so there is so much one can do about quality in that small frame. About the android logo should I instead use the 3d logo that was announced more recently? Also about the windows9x, I believe the titled icon was officially used by Microsoft for the release of 95 and 98, should I instead add that icon? |
@mohsenbakhit Just try to figure out which logo is most likely the correct/latest one (for both Android and Win9x), and then ask the maintainer (osu) to review/merge when you think this pull request is "ready" However, here are my notes:
|
@osy I think this PR is merge-ready. |
Adds:
Addressing #5938