Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lookup table #36

Merged
merged 5 commits into from
Aug 12, 2023
Merged

Lookup table #36

merged 5 commits into from
Aug 12, 2023

Conversation

utkarsh-1905
Copy link
Owner

@nimishmedatwal issues #24 and #5 are being fixed with this pull request. Review and find bugs, please

@utkarsh-1905 utkarsh-1905 added the enhancement New feature or request label Aug 8, 2023
@utkarsh-1905 utkarsh-1905 self-assigned this Aug 8, 2023
nimishmedatwal
nimishmedatwal suggested changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@nimishmedatwal nimishmedatwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Electives only the first elective is getting subject name.
image

nimishmedatwal
nimishmedatwal suggested changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@nimishmedatwal nimishmedatwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L getting mixed with Course name for some courses.
image

nimishmedatwal
nimishmedatwal suggested changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@nimishmedatwal nimishmedatwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we could just merge the cells instead of saying Lab Continue, I think it would look better.
image

@utkarsh-1905
Copy link
Owner Author

If we could just merge the cells instead of saying Lab Continue, I think it would look better. image

would need to change the basic structure of the table on highly conditional logic

@utkarsh-1905
Copy link
Owner Author

@nimishmedatwal updated logic to show all subject name, but need some UI changes to display names in good looking manner

@utkarsh-1905 utkarsh-1905 merged commit a7e5bae into main Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nimishmedatwal nimishmedatwal nimishmedatwal requested changes

Assignees

@utkarsh-1905 utkarsh-1905

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@utkarsh-1905 @nimishmedatwal