-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite assembler #5
Open
gipsond
wants to merge
84
commits into
master
Choose a base branch
from
chumsky
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… using module name to disambiguate
… NOT, STR, and TRAP
…tests individually
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rewrite of the assembler to use the
chumsky
parser combinator library (and its sister error presentation library,ariadne
). The main feature it enables is that the parsing step implicitly records the span of each parse tree element as aRange<usize>
, instead of storing&str
slices. This removes the need for explicit lifetime management which I expect would have made the old assembler difficult to maintain.The design of this rewrite differs in a few other key ways:
Result
s, rather than panicking.This rewrite also includes automated tests for error cases, something the original lacked.
There is at least one significant regression: some errors do not provide as much specific information, particularly lexical errors. For example, if a source includes the invalid operand
#OOPS
, the current assembler would point toOOPS
as an invalid decimal number, whereas this rewrite will simply indicate#OOPS
is an invalid token, but not why. This rewrite does indicate all of the same errors, but not with as much specificity in all cases, though this can be improved with future work.