Use per-device locks to update resource status #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlruys
reviewed
Apr 28, 2022
| # Parla tracks managed PArrays' locations | ||
| # Index into dict with id(array), then with device. True means the array is present there | ||
| # We use the unique id of the array as the key because PArray is an unhashable class | ||
| self._managed_parrays = {} | ||
|
|
||
| @staticmethod | ||
| def _initial_resources(): | ||
| return {dev: {name: amt for name, amt in dev.resources.items()} for dev in get_all_devices()} | ||
| res_dict = {} |
There was a problem hiding this comment.
just to give index; individual lock exists for each device. But I have no idea how to write it in more pythonic way :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses per-device locks to update resource status.
This PR requires CPU core modes to see performance improvements; do
git checkout cpu-test -- parla/cpu_impl.py.It improved 3x faster runtime compared to the main.