Add moon rotation #511
Merged
Add moon rotation #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
200km
added
priority::medium
200km
requested review from
suzuki-toshihir0,
t-hosonuma and
conjikidow
and removed request for
a team
t-hosonuma
reviewed
Oct 12, 2023
| } | ||
|
|
||
| libra::Matrix<3, 3> CalcDcmMeanEarthToPrincipalAxis() { | ||
| const double theta_x_rad = 0.285 * libra::arcsec_to_rad; |
There was a problem hiding this comment.
Could you please briefly explain the meaning of the magic numbers (ex,. 0.285) by adding comment lines, if possible?
There was a problem hiding this comment.
ファイル先頭のnoteに参考文献を書いています。基本的にはそこで定義されている補正係数です。
There was a problem hiding this comment.
承知致しました，参考文献が書いてあればコメント不要という方針であれば問題ありません．
他に気になる点はありませんでしたので，Approveします．
There was a problem hiding this comment.
わかりづらいと言う指摘だと思うので、コメントを追記しました。
There was a problem hiding this comment.
すみません。pushしたつもりでマージしましたが、し忘れていたのでPRを作りました。クイックにレビューお願いします。
t-hosonuma
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
#164
Description
I added the moon rotation definition.
Test results
I confirmed that the calculation result of
Simplemode is similar with the result ofIauMoonmode, which is calculated by SPICE.Impact
Minor update
Supplementary information
NA