Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify celestial rotation to suit coding rule #501

Merged
merged 11 commits into from
Oct 4, 2023
Merged

Modify celestial rotation to suit coding rule #501

merged 11 commits into from
Oct 4, 2023

Conversation

200km
Copy link
Member

@200km 200km commented Sep 30, 2023 •
edited
Loading

Related issues

#164

Description

  • Fix typo
  • Fix variables name

Test results

See CI

Impact

Patch

Supplementary information

NA

@200km 200km added priority::medium priority medium environment environment calculation minor update add functionality in a backwards compatible manner labels Sep 30, 2023
@200km 200km added this to the Major Update for v7.0.0 milestone Sep 30, 2023
@200km 200km self-assigned this Sep 30, 2023
@200km 200km requested review from sksat and a team as code owners September 30, 2023 18:41
@200km 200km requested review from suzuki-toshihir0, t-hosonuma and conjikidow and removed request for a team September 30, 2023 18:41
@200km 200km changed the title [WIP] Refactor celestial rotation Refactor celestial rotation Oct 3, 2023
@200km 200km changed the title Refactor celestial rotation Modify celestial rotation to suit coding rule Oct 3, 2023
@200km 200km added patch backwards compatible bug fixes and removed minor update add functionality in a backwards compatible manner labels Oct 3, 2023
t-hosonuma
t-hosonuma approved these changes Oct 4, 2023
View reviewed changes
Copy link

@t-hosonuma t-hosonuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

問題なさそうですのでApproveします．

@200km 200km merged commit 8268a21 into develop Oct 4, 2023
@200km 200km deleted the feature/refactor-celes-rotation branch October 4, 2023 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-hosonuma t-hosonuma t-hosonuma approved these changes

@sksat sksat Awaiting requested review from sksat sksat is a code owner

@suzuki-toshihir0 suzuki-toshihir0 Awaiting requested review from suzuki-toshihir0 suzuki-toshihir0 is a code owner automatically assigned from ut-issl/aocs

@conjikidow conjikidow Awaiting requested review from conjikidow conjikidow is a code owner automatically assigned from ut-issl/aocs

Assignees

@200km 200km

Labels
environment environment calculation patch backwards compatible bug fixes priority::medium priority medium
Projects
S2E
Archived in project
Milestone
Major Update for v7.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@200km @t-hosonuma