Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3.10.0 に core update #154

Merged
merged 4 commits into from
Aug 8, 2023
Merged

v3.10.0 に core update #154

merged 4 commits into from
Aug 8, 2023

Conversation

chutaro
Copy link
Contributor

@chutaro chutaro commented Aug 3, 2023 •
edited by seki-hiro
Loading

Issue

詳細

https://github.com/ut-issl/c2a-core/releases/tag/v3.10.0
user部に影響がある or 重要な PR はマージされた順に以下

検証結果

ビルドチェック (どちらもチェック)

  • SILSでのビルドチェックに通った(CIで確認)
  • vMicroでのビルドチェックに通った

動作確認チェック (いずれかをチェック)

  • SILSでアルゴリズムが想定通りに動いた
  • 実機でアルゴリズムが想定通りに動いた
  • (テレコマ試験の場合)コマンドファイルを使った試験をパスした

試験結果詳細記述場所 or 詳細ログ保存場所へのリンク

  • 図や表で記述する

補足

統合電気試験までに必要

@chutaro chutaro added the 🚀 priority::high priority high label Aug 3, 2023
@chutaro chutaro requested a review from sksat as a code owner August 3, 2023 04:29
@chutaro chutaro self-assigned this Aug 3, 2023
@chutaro chutaro requested a review from a team as a code owner August 3, 2023 04:29
@chutaro chutaro requested review from 200km, seki-hiro, suzuki-toshihir0 and conjikidow and removed request for a team August 3, 2023 04:29
@chutaro
Copy link
Contributor Author

chutaro commented Aug 3, 2023

pragma section の warning も消えた
#98 (comment)

@200km 200km added this to the 開発仮目標1 milestone Aug 3, 2023
@200km 200km added ✈️ priority::medium priority medium 🐳 major update Major update and removed 🚀 priority::high priority high labels Aug 3, 2023
200km
200km approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@200km 200km left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

質問一つだけですのでapproveします。

database/CMD_DB/ISSL6U_AOBC_CMD_DB_CMD_DB.csv
@@ -32,12 +32,12 @@ Comment,,,,,Type,Description,Type,Description,Type,Description,Type,Description,
**,Telemetry Generator,,,,,,,,,,,,,,,,,,,
,Cmd_GENERATE_TLM,OBC,0x0014,3,uint8_t,category,uint8_t,TLM_ID,uint8_t,送出回数,,,,,,,,,TLMパケット生成 (deprecated),
,Cmd_TG_GENERATE_TLM,OBC,0x0015,4,uint8_t,tlm id,uint8_t,dest flags,uint8_t,dest info,uint8_t,送出回数,,,,,,,自身の OBC のテレメを生成,
,Cmd_TG_GENERATE_HK_TLM,OBC,0x0016,1,uint8_t,tlm id,,,,,,,,,,,,,HK テレメを生成 (事実上，現在使われていない）,
,Cmd_TG_GENERATE_MS_TLM,OBC,0x0017,1,uint8_t,tlm id,,,,,,,,,,,,,MS テレメを生成,
,Cmd_TG_GENERATE_HP_TLM,OBC,0x0016,1,uint8_t,tlm id,,,,,,,,,,,,,High Priority テレメを生成 (事実上，現在使われていない）,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Q] 現在も使われていないなら、このコマンドはコメントアウトしても良いですかね？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

はい、良いと思います。
不要な core コマンドを削る作業は別PRでまとめてやりますか？（tobc, mif なども揃えたいなと思い）

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

わかりました。別PRでまとめてやるので、マージ作業進めてください。

@chutaro chutaro changed the title WIP: v3.10.0 に core update v3.10.0 に core update Aug 8, 2023
@chutaro
Copy link
Contributor Author

chutaro commented Aug 8, 2023

@seki-hiro パッと見て #161 とコンフリクト無さそうなので、vMicroビルド通りしだい早めにマージしたいです

seki-hiro
seki-hiro approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@seki-hiro seki-hiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vMicro build確認しました。

@chutaro chutaro force-pushed the feature/core_update_230803 branch from 902d33f to 6e4c3dd Compare August 8, 2023 14:14
@chutaro chutaro merged commit 99b42f8 into develop Aug 8, 2023
@chutaro chutaro deleted the feature/core_update_230803 branch August 8, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@200km 200km 200km approved these changes

@seki-hiro seki-hiro seki-hiro approved these changes

@sksat sksat Awaiting requested review from sksat sksat is a code owner

@suzuki-toshihir0 suzuki-toshihir0 Awaiting requested review from suzuki-toshihir0 suzuki-toshihir0 is a code owner automatically assigned from ut-issl/aocs

@conjikidow conjikidow Awaiting requested review from conjikidow conjikidow is a code owner automatically assigned from ut-issl/aocs

Assignees

@chutaro chutaro

Labels
✈️ priority::medium priority medium 🐳 major update Major update
Projects
None yet
Milestone
開発仮目標1
Development

Successfully merging this pull request may close these issues.
3 participants
@chutaro @200km @seki-hiro