add more recording topics, make it a flag #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvsikand
commented
Sep 22, 2020
| @@ -51,6 +51,69 @@ DEFINE_string(joystick_topic, | |||
| // The button used to indicate start of autonomous operation. | |||
| DEFINE_uint64(start_btn_idx, 0, "Start button index"); | |||
|
|
|||
| DEFINE_string(record_topics, "/autonomy_arbiter/enabled \ | |||
There was a problem hiding this comment.
Does anyone have a better idea on how to set a default here? and/or if there's some of thes topics we definitely don't want?
There was a problem hiding this comment.
This is better done as read from a config file. I don't think it is a good idea to require such long CLI arguments.
joydeep-b
requested changes
Sep 22, 2020
| @@ -51,6 +51,69 @@ DEFINE_string(joystick_topic, | |||
| // The button used to indicate start of autonomous operation. | |||
| DEFINE_uint64(start_btn_idx, 0, "Start button index"); | |||
|
|
|||
| DEFINE_string(record_topics, "/autonomy_arbiter/enabled \ | |||
There was a problem hiding this comment.
This is better done as read from a config file. I don't think it is a good idea to require such long CLI arguments.
| @@ -1,4 +1,4 @@ | |||
| <launch> | |||
| <node pkg="ut_jackal" type="enml" name="enml" args='-c="../enml/config" -m="../enml/maps" -d1' cwd="node" /> | |||
| <node pkg="ut_jackal" type="navigation" name="navigation" args='--maps_dir ../navigation/maps' cwd="node" /> | |||
| <node pkg="ut_jackal" type="navigation" name="navigation" args='--maps_dir ../enml/maps' cwd="node" /> | |||
There was a problem hiding this comment.
Just checking: was this change intentional?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the lab to-do's
Also, this fixes a bug in autonomy.launch