Update Readme.md #45
Merged
Update Readme.md #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a step to pull all submodules
joydeep-b
requested changes
Jan 27, 2023
src/navigation/navigation.cc
Outdated
| @@ -533,6 +533,7 @@ bool Navigation::GetCarrot(Vector2f& carrot) { | |||
| // V2COMP(robot_loc_), V2COMP(v0), V2COMP(v1), (v0 - v1).norm()); | |||
| const int num_intersections = geometry::CircleLineIntersection<float>( | |||
| robot_loc_, params_.carrot_dist, v0, v1, &r0, &r1); | |||
| //TODO Bugfix: say set a nav goal -> goal reached -> switched to manual and start moving -> as soon as its gets away from the prev nav target, the following error starts continuously printing. So once nav target reached this following line should not be done. | |||
There was a problem hiding this comment.
You didn't want to commit this with this PR, did you?
There was a problem hiding this comment.
Oh I didn't want to create a separate PR for such a little thing. Hence included it with this. Is there any issue with it?
There was a problem hiding this comment.
I actually did not understand this issue, could you move this to the issue tracker? https://github.com/ut-amrl/graph_navigation/issues
There was a problem hiding this comment.
Removed the todo from navigation.cc and moved it to #46
joydeep-b
requested changes
Jan 27, 2023
src/navigation/navigation.cc
Outdated
| @@ -533,6 +533,7 @@ bool Navigation::GetCarrot(Vector2f& carrot) { | |||
| // V2COMP(robot_loc_), V2COMP(v0), V2COMP(v1), (v0 - v1).norm()); | |||
| const int num_intersections = geometry::CircleLineIntersection<float>( | |||
| robot_loc_, params_.carrot_dist, v0, v1, &r0, &r1); | |||
| //TODO Bugfix: say set a nav goal -> goal reached -> switched to manual and start moving -> as soon as its gets away from the prev nav target, the following error starts continuously printing. So once nav target reached this following line should not be done. | |||
There was a problem hiding this comment.
I actually did not understand this issue, could you move this to the issue tracker? https://github.com/ut-amrl/graph_navigation/issues
Moved the todo to an issue #46
joydeep-b
approved these changes
Jan 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a step to pull all submodules